Refactor S3 store creation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 7, 2022 14:20
added 8 commits
January 25, 2023 11:30
janjagusch
reviewed
Jan 26, 2023
minimalkv/_get_store.py
Outdated
Comment on lines
120
to
127
| if old_wrappers: | ||
| warnings.warn( | ||
| """ | ||
| Using wrappers as part of the scheme is deprecated. Please specify wrappers as part of the fragment instead, | ||
| e.g. "s3://...#wrap:readonly+urlencode" instead of "s3+readonly+urlencode://...". | ||
| """, | ||
| DeprecationWarning, | ||
| ) |
There was a problem hiding this comment.
This was already previously deprecated, right? It's nothing we've introduced in this PR, right?
There was a problem hiding this comment.
There was no warning given previously, so we should probably keep it like that for now. I removed the warning 👍🏼
simonbohnen
requested review from
janjagusch
and removed request for
xhochy,
fjetter,
siboehm and
mlondschien
janjagusch
approved these changes
Feb 6, 2023
xhochy
requested changes
Feb 6, 2023
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
…into s3-store-creation
xhochy
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boto3StoreandBotoStore) to the S3FSStoreIf the changes in this PR look good, I will create separate PRs for the other stores from #71.
docs/changes.rstentry